Clean up systray methods, make more QML-friendly #4687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4687 +/- ##
==========================================
- Coverage 56.42% 56.41% -0.01%
==========================================
Files 138 138
Lines 17068 17068
==========================================
- Hits 9630 9629 -1
- Misses 7438 7439 +1
|
camilasan
approved these changes
Jul 4, 2022
mgallien
reviewed
Jul 6, 2022
claucambra
force-pushed
the
work/systray-cleanup
branch
3 times, most recently
from
15fb04c to
1f88ff1
Compare
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
claucambra
force-pushed
the
work/systray-cleanup
branch
from
1f88ff1 to
b712eb9
Compare
|
AppImage file: Nextcloud-PR-4687-1f88ff14b4742b55cbb4570b64bdf9f1473c2c83-x86_64.AppImage |
|
SonarCloud Quality Gate failed. |
|
Rebased and conflicts fixed |
mgallien
approved these changes
Jul 6, 2022
|
/backport to stable-3.5 |
|
/backport to stable-3.5 |
|
The backport to stable-3.5 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Systrayclass has at the moment several unnecessaryQ_INVOKABLEmethods, and other methods that could be simplified into propertiesThis PR cleans up and refactors these methods to make the code cleaner and more QML-friendly
Signed-off-by: Claudio Cambra claudio.cambra@gmail.com