Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tray window opening code for clarity and efficiency #4688

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Refactor tray window opening code for clarity and efficiency #4688

merged 1 commit into from
Jul 12, 2022

Conversation

claucambra
Copy link
Collaborator

We now hold a reference to the QML tray window in Systray and handle window positioning, showing, and hiding within Systray

This makes what is going on much clearer

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@claucambra claucambra force-pushed the bugfix/refactor-tray-window-open branch from 53711d4 to 61c63cb Compare June 30, 2022 15:56
@codecov
Copy link

codecov bot commented Jun 30, 2022 •
edited
Loading

Codecov Report

Merging #4688 (724a570) into master (b707aef) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 724a570 differs from pull request most recent head ce9e4a9. Consider uploading reports for the commit ce9e4a9 to get more accurate results

@@            Coverage Diff             @@
##           master    #4688      +/-   ##
==========================================
- Coverage   56.51%   56.41%   -0.10%     
==========================================
  Files         138      138              
  Lines       17068    17068              
==========================================
- Hits         9646     9629      -17     
- Misses       7422     7439      +17
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/hydrationjob.cpp 52.68% <0.00%> (-3.77%) ⬇️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 83.84% <0.00%> (-2.63%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 75.42% <0.00%> (-1.93%) ⬇️
src/libsync/syncengine.cpp 85.19% <0.00%> (-0.55%) ⬇️
src/libsync/propagatedownload.cpp 65.18% <0.00%> (+1.03%) ⬆️

@claucambra claucambra self-assigned this Jun 30, 2022
mgallien
mgallien reviewed Jul 6, 2022
View reviewed changes
src/gui/systray.cpp Outdated Show resolved Hide resolved
src/gui/systray.cpp Outdated Show resolved Hide resolved
@claucambra claucambra force-pushed the bugfix/refactor-tray-window-open branch from 61c63cb to acd65c0 Compare July 6, 2022 09:49
@claucambra
Copy link
Collaborator Author

Rebased and resolved conflicts

@claucambra claucambra force-pushed the bugfix/refactor-tray-window-open branch 2 times, most recently from 724a570 to 689f441 Compare July 8, 2022 10:47
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4688-689f441e5873222f9f686357b86c4b6a16e44580-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@camilasan
Copy link
Member

/backport to stable-3.5

@camilasan camilasan force-pushed the bugfix/refactor-tray-window-open branch from 689f441 to f6de377 Compare July 12, 2022 18:22
@claucambra
Refactor tray window opening code for clarity and efficiency
ce9e4a9 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@claucambra claucambra force-pushed the bugfix/refactor-tray-window-open branch from f6de377 to ce9e4a9 Compare July 12, 2022 20:54
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4688-ce9e4a99c0467617bfcecea0c7639a9ed7018198-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@claucambra claucambra merged commit fc16d82 into master Jul 12, 2022
@claucambra claucambra deleted the bugfix/refactor-tray-window-open branch July 12, 2022 21:27
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 12, 2022
Closed
@claucambra claucambra mentioned this pull request Jul 15, 2022
Merged
@mgallien mgallien added this to the 3.6.0 milestone Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilasan camilasan camilasan approved these changes

@mgallien mgallien mgallien approved these changes

@allexzander allexzander Awaiting requested review from allexzander

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@claucambra @nextcloud-desktop-bot @camilasan @mgallien