Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/vfs windows thumbnails #4713

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Feature/vfs windows thumbnails #4713

merged 1 commit into from
Jul 29, 2022

Conversation

allexzander
Copy link
Contributor

No description provided.

@allexzander allexzander linked an issue Jul 8, 2022 that may be closed by this pull request
Thumbnails of photos with Virtual Files #3407
Closed
3 tasks
@codecov
Copy link

codecov bot commented Jul 8, 2022 •
edited
Loading

Codecov Report

Merging #4713 (0e84a4a) into master (d856e86) will increase coverage by 0.40%.
The diff coverage is 49.38%.

❗ Current head 0e84a4a differs from pull request most recent head 001deac. Consider uploading reports for the commit 001deac to get more accurate results

@@            Coverage Diff             @@
##           master    #4713      +/-   ##
==========================================
+ Coverage   56.41%   56.81%   +0.40%     
==========================================
  Files         138      138              
  Lines       17069    17142      +73     
==========================================
+ Hits         9629     9739     +110     
+ Misses       7440     7403      -37
Impacted Files Coverage Δ
src/common/utility.h 0.00% <ø> (ø)
src/common/utility_win.cpp 43.18% <0.00%> (-5.05%) ⬇️
src/common/vfs.h 52.38% <ø> (ø)
src/libsync/vfs/cfapi/cfapiwrapper.h 0.00% <ø> (ø)
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.71% <45.16%> (-0.71%) ⬇️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 87.45% <96.29%> (+3.60%) ⬆️
src/libsync/propagatedownload.cpp 65.18% <0.00%> (-0.15%) ⬇️
src/common/vfs.cpp 67.46% <0.00%> (+0.79%) ⬆️
src/libsync/clientsideencryption.cpp 26.88% <0.00%> (+1.61%) ⬆️
... and 6 more

@allexzander allexzander force-pushed the feature/vfs-windows-thumbnails branch 2 times, most recently from d87c120 to 713d23a Compare July 12, 2022 08:29
@PhilippSchlesinger PhilippSchlesinger mentioned this pull request Jul 12, 2022
Closed
3 tasks
@allexzander allexzander force-pushed the feature/vfs-windows-thumbnails branch 2 times, most recently from eb97b0b to e6e7f50 Compare July 13, 2022 08:36
@allexzander allexzander marked this pull request as ready for review July 13, 2022 08:36
@allexzander allexzander force-pushed the feature/vfs-windows-thumbnails branch from af27e09 to e1cb711 Compare July 14, 2022 11:20
claucambra
claucambra approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small nitpicks from me

src/common/cfapishellextensionsipcconstants.h Outdated Show resolved Hide resolved
src/libsync/vfs/cfapi/cfapiwrapper.cpp Show resolved Hide resolved
@claucambra
Copy link
Collaborator

Oh, the CfApiShellExtensionsIPCTest test is failing

@allexzander
Copy link
Contributor Author

Oh, the CfApiShellExtensionsIPCTest test is failing

ahh, most likely just another random failure with this VM of GH. I don't know how to debug these failures :(

mgallien
mgallien reviewed Jul 25, 2022
View reviewed changes
src/gui/folder.h Outdated Show resolved Hide resolved
NEXTCLOUD.cmake Show resolved Hide resolved
NEXTCLOUD.cmake Show resolved Hide resolved
src/gui/folder.cpp Outdated Show resolved Hide resolved
src/libsync/vfs/cfapi/shellext/thumbnailprovideripc.h Show resolved Hide resolved
mgallien
mgallien reviewed Jul 25, 2022
View reviewed changes
src/gui/folder.cpp Outdated Show resolved Hide resolved
@allexzander allexzander requested a review from mgallien July 27, 2022 07:33
@allexzander allexzander force-pushed the feature/vfs-windows-thumbnails branch 5 times, most recently from 6791770 to fd30889 Compare July 28, 2022 14:43
mgallien
mgallien reviewed Jul 28, 2022
View reviewed changes
NEXTCLOUD.cmake Show resolved Hide resolved
src/libsync/vfs/cfapi/shellext/CMakeLists.txt Outdated Show resolved Hide resolved
src/gui/application.cpp Show resolved Hide resolved
src/gui/shellextensionsserver.cpp Outdated Show resolved Hide resolved
src/libsync/vfs/cfapi/CMakeLists.txt Outdated Show resolved Hide resolved
src/libsync/vfs/cfapi/shellext/thumbnailprovideripc.cpp Show resolved Hide resolved
@allexzander allexzander force-pushed the feature/vfs-windows-thumbnails branch 3 times, most recently from 0e84a4a to b99a208 Compare July 29, 2022 06:50
@allexzander allexzander requested a review from mgallien July 29, 2022 06:51
@mgallien
Copy link
Collaborator

ready to go
please @allexzander clean history, I approve and you merge it 😄

@allexzander allexzander force-pushed the feature/vfs-windows-thumbnails branch from b99a208 to b6f05dd Compare July 29, 2022 15:49
@allexzander
Implement COM Dll for CfApi shell extensins. Implement Thumbnail Prov…
001deac 
…ider.

Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the feature/vfs-windows-thumbnails branch from b6f05dd to 001deac Compare July 29, 2022 16:27
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4713-001deace2d5cc9c0c4bcf782ac21f42fe17177d7-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@allexzander allexzander merged commit 3383a58 into master Jul 29, 2022
@allexzander allexzander deleted the feature/vfs-windows-thumbnails branch July 29, 2022 16:57
@mgallien mgallien added this to the 3.6.0 milestone Aug 1, 2022
@robermad1986
Copy link

Trying this feature in the RC2 works wonderful for me so far!

@allexzander
Copy link
Contributor Author

Trying this feature in the RC2 works wonderful for me so far!

Thank you so much for testing it.

@spacehitchhiker42 spacehitchhiker42 mentioned this pull request Sep 8, 2022
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

Thumbnails of photos with Virtual Files
5 participants
@allexzander @claucambra @mgallien @nextcloud-desktop-bot @robermad1986