Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ActivityItemContent QML paintedWidth errors #4738

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Fix ActivityItemContent QML paintedWidth errors #4738

merged 1 commit into from
Jul 18, 2022

Conversation

claucambra
Copy link
Collaborator

This should fix the logs being littered with the following:

2022-07-15 12:48:57:132 [ warning default qrc:/qml/src/gui/tray/ActivityItemContent.qml:89 ]:	qrc:/qml/src/gui/tray/ActivityItemContent.qml:89: TypeError: Cannot read property 'paintedHeight' of null
2022-07-15 12:48:57:132 [ warning default qrc:/qml/src/gui/tray/ActivityItemContent.qml:84 ]:	qrc:/qml/src/gui/tray/ActivityItemContent.qml:84: TypeError: Cannot read property 'paintedWidth' of null

@claucambra claucambra self-assigned this Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022 •
edited
Loading

Codecov Report

Merging #4738 (4fd980a) into master (ee5c453) will not change coverage.
The diff coverage is n/a.

❗ Current head 4fd980a differs from pull request most recent head e3d897c. Consider uploading reports for the commit e3d897c to get more accurate results

@@           Coverage Diff           @@
##           master    #4738   +/-   ##
=======================================
  Coverage   56.40%   56.40%           
=======================================
  Files         138      138           
  Lines       17070    17070           
=======================================
  Hits         9629     9629           
  Misses       7441     7441

@claucambra
Copy link
Collaborator Author

/backport to stable-3.5

@claucambra
Fix ActivityItemContent QML paintedWidth errors
e3d897c 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@claucambra claucambra force-pushed the bugfix/painted-width-qml-errors branch from 4fd980a to e3d897c Compare July 18, 2022 13:13
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4738-e3d897cb7fe53148bdca237a927050c2056f5230-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit 0cea856 into master Jul 18, 2022
@claucambra claucambra deleted the bugfix/painted-width-qml-errors branch July 18, 2022 14:05
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 18, 2022
Merged
@mgallien mgallien added this to the 3.6.0 milestone Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan camilasan approved these changes

@allexzander allexzander Awaiting requested review from allexzander

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@claucambra @nextcloud-desktop-bot @mgallien @camilasan