Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set UnifiedSearchResultNothingFound visibility less messily #4751

Merged

Conversation

claucambra
Copy link
Collaborator

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@claucambra claucambra self-assigned this Jul 18, 2022
@claucambra claucambra force-pushed the bugfix/unmessify-UnifiedSearchResultNothingFound branch from 289a159 to c88471c Compare July 26, 2022 09:42
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #4751 (69e419c) into master (7e53280) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 69e419c differs from pull request most recent head 7882e22. Consider uploading reports for the commit 7882e22 to get more accurate results

@@            Coverage Diff             @@
##           master    #4751      +/-   ##
==========================================
+ Coverage   57.15%   57.20%   +0.05%     
==========================================
  Files         138      138              
  Lines       17135    17133       -2     
==========================================
+ Hits         9793     9801       +8     
+ Misses       7342     7332      -10     
Impacted Files Coverage Δ
src/libsync/owncloudpropagator.h 73.28% <0.00%> (-1.16%) ⬇️
src/libsync/owncloudpropagator.cpp 86.00% <0.00%> (-0.03%) ⬇️
src/libsync/syncengine.cpp 87.22% <0.00%> (+0.02%) ⬆️
src/libsync/discovery.cpp 84.66% <0.00%> (+0.09%) ⬆️
src/libsync/propagatedownload.cpp 65.33% <0.00%> (+0.44%) ⬆️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.65% <0.00%> (+0.45%) ⬆️
src/libsync/propagateremotemkdir.cpp 65.24% <0.00%> (+0.70%) ⬆️
src/libsync/propagateuploadng.cpp 83.89% <0.00%> (+1.49%) ⬆️

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@claucambra claucambra requested a review from mgallien July 27, 2022 10:16
@claucambra claucambra requested a review from mgallien August 4, 2022 12:47
@claucambra claucambra force-pushed the bugfix/unmessify-UnifiedSearchResultNothingFound branch 2 times, most recently from e29b216 to c88471c Compare September 7, 2022 13:00
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@claucambra claucambra force-pushed the bugfix/unmessify-UnifiedSearchResultNothingFound branch from c88471c to 7882e22 Compare September 7, 2022 13:01
@claucambra claucambra merged commit a40202c into master Sep 7, 2022
@claucambra claucambra deleted the bugfix/unmessify-UnifiedSearchResultNothingFound branch September 7, 2022 13:01
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4751-e29b2160f3d61d9ca8ff3517222813f8017f1f4e-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

77.8% 77.8% Coverage
0.0% 0.0% Duplication

@mgallien mgallien added this to the 3.7.0 milestone Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants