Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure debug archive contents are readable by any user #4756

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

claucambra
Copy link
Collaborator

Fixes #4626

@claucambra claucambra self-assigned this Jul 19, 2022
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #4756 (bb034b8) into master (db90f5b) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4756      +/-   ##
==========================================
- Coverage   56.56%   56.50%   -0.06%     
==========================================
  Files         138      138              
  Lines       17069    17069              
==========================================
- Hits         9655     9645      -10     
- Misses       7414     7424      +10     
Impacted Files Coverage Δ
src/libsync/propagatedownload.cpp 64.14% <0.00%> (-1.04%) ⬇️
src/libsync/discovery.cpp 84.56% <0.00%> (-0.30%) ⬇️

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@claucambra claucambra force-pushed the bugfix/debug-archive-permissions branch from f22ccc6 to bb034b8 Compare July 21, 2022 11:47
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4756-bb034b8bf4065e17ee925fe09e8bfd149d074d90-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@claucambra claucambra merged commit b78abe2 into master Jul 21, 2022
@claucambra claucambra deleted the bugfix/debug-archive-permissions branch July 21, 2022 13:08
@claucambra
Copy link
Collaborator Author

/backport to stable-3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Mac OS - the log directory contained in the zip file has the ACL 0400
4 participants