Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debian Bullseye build #4773

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Add Debian Bullseye build #4773

merged 1 commit into from
Aug 3, 2022

Conversation

ivaradi
Copy link
Contributor

@ivaradi ivaradi commented Jul 22, 2022

This patch adds a Debian Bullseye-specific build, since testing is no longer compatible with Bullseye.

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #4773 (b53f825) into master (3400df4) will decrease coverage by 0.15%.
The diff coverage is n/a.

❗ Current head b53f825 differs from pull request most recent head 6b3ba1f. Consider uploading reports for the commit 6b3ba1f to get more accurate results

@@            Coverage Diff             @@
##           master    #4773      +/-   ##
==========================================
- Coverage   56.65%   56.50%   -0.16%     
==========================================
  Files         138      138              
  Lines       17143    17069      -74     
==========================================
- Hits         9713     9645      -68     
+ Misses       7430     7424       -6     
Impacted Files Coverage Δ
src/libsync/creds/abstractcredentials.cpp 14.28% <0.00%> (-57.15%) ⬇️
src/libsync/syncfilestatustracker.cpp 88.95% <0.00%> (-4.30%) ⬇️
src/libsync/account.cpp 36.60% <0.00%> (-2.25%) ⬇️
src/libsync/clientsideencryption.cpp 25.27% <0.00%> (-1.62%) ⬇️
src/libsync/propagatedownload.cpp 64.14% <0.00%> (-1.04%) ⬇️
src/libsync/syncengine.cpp 85.74% <0.00%> (-0.92%) ⬇️
src/common/vfs.cpp 66.66% <0.00%> (-0.80%) ⬇️
src/common/vfs.h 52.38% <0.00%> (ø)
src/common/utility.h 0.00% <0.00%> (ø)
src/libsync/vfs/cfapi/vfs_cfapi.cpp 86.46% <0.00%> (+1.36%) ⬆️
... and 3 more

@ivaradi ivaradi force-pushed the bullseye branch 2 times, most recently from eea6484 to 5e1eeef Compare July 25, 2022 05:47
@ivaradi ivaradi force-pushed the bullseye branch 6 times, most recently from fe21600 to d520c2f Compare August 2, 2022 04:28
@ivaradi ivaradi force-pushed the bullseye branch 4 times, most recently from 3675749 to d0bd2a9 Compare August 3, 2022 10:50
@claucambra
Copy link
Collaborator

@ivaradi Please only rebase before merging if possible, this should prevent the CI pipeline being run unnecessarily

@ivaradi
Copy link
Contributor Author

ivaradi commented Aug 3, 2022

@ivaradi Please only rebase before merging if possible, this should prevent the CI pipeline being run unnecessarily

OK, but I was hoping that by rebasing and thus triggering the pipeline, I can trigger a review too, for which I have been waiting for almost two weeks. And it finally worked ;)

Anyway, there is also the problem with the SonarCloud analysis, that fails all the time. Is there something I can do to make it work?

@claucambra
Copy link
Collaborator

@ivaradi Please only rebase before merging if possible, this should prevent the CI pipeline being run unnecessarily

OK, but I was hoping that by rebasing and thus triggering the pipeline, I can trigger a review too, for which I have been waiting for almost two weeks. And it finally worked ;)

Pinging one of us assigned to review would have had the same effect without slowing down the CI pipeline across the repo

Anyway, there is also the problem with the SonarCloud analysis, that fails all the time. Is there something I can do to make it work?

The error is unrelated to the changes in this PR so it is ok, if the rest of the pipeline succeeds it is safe to merge

@ivaradi
Copy link
Contributor Author

ivaradi commented Aug 3, 2022

@ivaradi Please only rebase before merging if possible, this should prevent the CI pipeline being run unnecessarily

OK, but I was hoping that by rebasing and thus triggering the pipeline, I can trigger a review too, for which I have been waiting for almost two weeks. And it finally worked ;)

Pinging one of us assigned to review would have had the same effect without slowing down the CI pipeline across the repo

What is the best way to ping reviewers?

Anyway, there is also the problem with the SonarCloud analysis, that fails all the time. Is there something I can do to make it work?

The error is unrelated to the changes in this PR so it is ok, if the rest of the pipeline succeeds it is safe to merge

Yes, but I am not allowed to merge if one or more checks fail. So, please, merge it.

@claucambra
Copy link
Collaborator

claucambra commented Aug 3, 2022

@ivaradi Please only rebase before merging if possible, this should prevent the CI pipeline being run unnecessarily

OK, but I was hoping that by rebasing and thus triggering the pipeline, I can trigger a review too, for which I have been waiting for almost two weeks. And it finally worked ;)

Pinging one of us assigned to review would have had the same effect without slowing down the CI pipeline across the repo

What is the best way to ping reviewers?

Feel free to add a comment with a tag like @ivaradi (if a review is done and changes are requested, once the changes are done you should be able to re-request a review in the right-sidebar)

Anyway, there is also the problem with the SonarCloud analysis, that fails all the time. Is there something I can do to make it work?

The error is unrelated to the changes in this PR so it is ok, if the rest of the pipeline succeeds it is safe to merge

Yes, but I am not allowed to merge if one or more checks fail. So, please, merge it.

Will do when the CI pipelines are done

Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4773-6b3ba1fe3acbe8e28b3a0f2c83b7b5f1df8c07cf-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit 8a0c335 into nextcloud:master Aug 3, 2022
@ivaradi ivaradi deleted the bullseye branch August 4, 2022 05:35
@ivaradi
Copy link
Contributor Author

ivaradi commented Aug 4, 2022

/backport to stable-3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants