Double-clicking tray icon opens currently-selected user's local folder (if available)

[claucambra]

Closes #1184

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

[mgallien]

can you add this to the user documentation ?
without that nobody will ever discover this hidden feature
I would have never known that systray icon can behave differently when double clicked

[claucambra]

can you add this to the user documentation ?
without that nobody will ever discover this hidden feature
I would have never known that systray icon can behave differently when double clicked

I added a line saying double-clicking will open the current user's locally synced folder

[allexzander]

@claucambra The feature works well, however, I am surprised one of the test cases is in fact broken:

FAIL!  : TestFolderWatcher::testMove3LevelDirWithFile() 'waitForPathChanged(_rootPath + "/a/b/c/empty.txt")' returned FALSE. ()
..\..\..\test\testfolderwatcher.cpp(170) : failure location

Maybe, just try to rebase the branch first, and you might get lucky.

[allexzander]

@claucambra My bad. It happened just 2 times and does not happen to me locally. Looks like random failure in unit tests :(

[claucambra]

@claucambra The feature works well, however, I am surprised one of the test cases is in fact broken:

FAIL!  : TestFolderWatcher::testMove3LevelDirWithFile() 'waitForPathChanged(_rootPath + "/a/b/c/empty.txt")' returned FALSE. ()
..\..\..\test\testfolderwatcher.cpp(170) : failure location

Maybe, just try to rebase the branch first, and you might get lucky.

TestFolderWatcher seems to fail pretty randomly :(

[nextcloud-desktop-bot]

AppImage file: Nextcloud-PR-4774-2b598d1820b2a612cacc332424c72f72e2c42458-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication