Clean up TalkReplyTextField, remove unnecessary parent Item #4790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
allexzander
approved these changes
Aug 2, 2022
mgallien
approved these changes
Aug 2, 2022
|
AppImage file: Nextcloud-PR-4790-c74c4667258a451d43d06396bcf6036fd0b7eccc-x86_64.AppImage |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #4790 +/- ##
==========================================
+ Coverage 56.80% 56.81% +0.01%
==========================================
Files 138 138
Lines 17142 17142
==========================================
+ Hits 9737 9740 +3
+ Misses 7405 7402 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case, the Item for the TalkReplyTextField is not needed and can be removed. This should also help simplify the focus chain when it comes to keyboard navigation