Always run MSI with full UI. #4801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4801 +/- ##
==========================================
+ Coverage 56.80% 56.83% +0.03%
==========================================
Files 138 138
Lines 17142 17142
==========================================
+ Hits 9737 9743 +6
+ Misses 7405 7399 -6
|
claucambra
approved these changes
Aug 2, 2022
Signed-off-by: alex-z <blackslayer4@gmail.com>
allexzander
force-pushed
the
bugfix/always-run-msi-with-full-ui
branch
from
dfe0cff to
f3c10ac
Compare
|
/backport to stable-3.5 |
|
AppImage file: Nextcloud-PR-4801-f3c10ac3a4f5ecbc8260134fc945b2d12e87323f-x86_64.AppImage |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: alex-z blackslayer4@gmail.com
Not rebooting when running the MSI may result in Explorer.exe failing to restart even though it is registered with Restart Manager by default. Running the MSI with full UI allows displaying the restart prompt and allows to cancel the update if accidentally started when not needed.
The downside is - the full UI sequence needs to be controlled by the user (selecting a folder, clicking next, etc.) making the update a bit less convenient, but, fully-controlled and reliable.
Switching to MSIX in future, would allows us to have a better UX with updates.