Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CFAPI shell extensions variables to root CMakeLists. #4810

Merged

Conversation

allexzander
Copy link
Contributor

Signed-off-by: alex-z blackslayer4@gmail.com

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the bugfix/move-cfpaishellext-vars-to-rootcmakelists branch from ba10bb9 to 3400df4 Compare August 3, 2022 11:55
@allexzander
Copy link
Contributor Author

@mgallien Done

@allexzander allexzander requested a review from mgallien August 3, 2022 11:56
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #4810 (3400df4) into master (4f85f7a) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4810      +/-   ##
==========================================
- Coverage   56.80%   56.65%   -0.15%     
==========================================
  Files         138      138              
  Lines       17142    17143       +1     
==========================================
- Hits         9737     9713      -24     
- Misses       7405     7430      +25     
Impacted Files Coverage Δ
src/common/utility.h 0.00% <ø> (ø)
src/common/utility_win.cpp 42.98% <0.00%> (-0.20%) ⬇️
src/libsync/vfs/cfapi/hydrationjob.cpp 52.68% <0.00%> (-3.77%) ⬇️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 85.09% <0.00%> (-2.36%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 72.43% <0.00%> (-1.83%) ⬇️
src/libsync/syncengine.cpp 86.65% <0.00%> (-0.55%) ⬇️

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4810-3400df461d2ad0dd39b8f2d8aaa0eef6d7f3fa44-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander merged commit 3487b09 into master Aug 3, 2022
@allexzander allexzander deleted the bugfix/move-cfpaishellext-vars-to-rootcmakelists branch August 3, 2022 13:26
@mgallien mgallien added this to the 3.6.0 milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants