ensure SyncEngine use an initialized instance of SyncOptions #4816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
force-pushed
the
bugfix/ensureSyncOptionsAreInitialized
branch
from
c578587 to
48d4b24
Compare
Codecov Report
@@ Coverage Diff @@
## master #4816 +/- ##
==========================================
+ Coverage 56.79% 57.22% +0.43%
==========================================
Files 138 138
Lines 17143 17144 +1
==========================================
+ Hits 9736 9811 +75
+ Misses 7407 7333 -74
|
allexzander
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Looks nice. @mgallien @claucambra I'd say, we need to have 2 constructors for SyncEngine ideally, such that one that does not take SyncOptions as a parameter will always do the initialization job inside, and the other one will be used when we need to pass empty SyncOptions.
Just an idea for refactoring.
claucambra
approved these changes
Aug 8, 2022
will prevent nextcloudcmd command line client from ignoring the settings handled by SyncOptions Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
allexzander
force-pushed
the
bugfix/ensureSyncOptionsAreInitialized
branch
from
48d4b24 to
8551a14
Compare
|
AppImage file: Nextcloud-PR-4816-8551a14c48bbfac15785a4cc00ab19aa9fc46f3e-x86_64.AppImage |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will prevent nextcloudcmd command line client from ignoring the settings
handled by SyncOptions
Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com