Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align, resize, and layout everything uniformly in the unified search view #4829

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

claucambra
Copy link
Collaborator

Addresses a point in #4434

Screen.Recording.2022-08-09.at.00.22.59.mov

Screenshot 2022-08-09 at 00 22 03

@claucambra claucambra self-assigned this Aug 8, 2022
@claucambra claucambra force-pushed the feature/unified-search-alignments branch from ba9d3f5 to d44ad50 Compare August 8, 2022 22:55
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #4829 (1245586) into master (eb4e8ad) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 1245586 differs from pull request most recent head 316f398. Consider uploading reports for the commit 316f398 to get more accurate results

@@           Coverage Diff           @@
##           master    #4829   +/-   ##
=======================================
  Coverage   57.17%   57.18%           
=======================================
  Files         138      138           
  Lines       17133    17133           
=======================================
+ Hits         9796     9797    +1     
+ Misses       7337     7336    -1     
Impacted Files Coverage Δ
src/libsync/propagatedownload.cpp 65.18% <0.00%> (+0.14%) ⬆️

@jancborchardt
Copy link
Member

Looks very good! 2 details:

  • The content of the message doesnt need to be repeated in a tooltip/title
  • In the 3rd Talk notification (the one with the black Talk icon), the Talk icon is cut iff as it's in a circle. It should show the whole icon properly though, like for Calendar

@claucambra claucambra force-pushed the feature/unified-search-alignments branch from d44ad50 to 6714f96 Compare August 10, 2022 12:41
@claucambra
Copy link
Collaborator Author

claucambra commented Aug 10, 2022

  • The content of the message doesnt need to be repeated in a tooltip/title

The tooltip presents the text in the unified search result fully (i.e. without eliding). Would you still want the tooltip removed?

  • In the 3rd Talk notification (the one with the black Talk icon), the Talk icon is cut iff as it's in a circle. It should show the whole icon properly though, like for Calendar

Thanks, good catch! Fixed now:

Screenshot 2022-08-10 at 14 42 15

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good now! :)

@mgallien mgallien force-pushed the feature/unified-search-alignments branch from 6714f96 to 1245586 Compare September 5, 2022 14:29
…view

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@mgallien mgallien force-pushed the feature/unified-search-alignments branch from 1245586 to 316f398 Compare September 6, 2022 07:02
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4829-316f3981abc6a007750f81b351fd8ecbed41f2ab-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 05d3c7a into master Sep 6, 2022
@mgallien mgallien deleted the feature/unified-search-alignments branch September 6, 2022 07:28
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

58.8% 58.8% Coverage
0.0% 0.0% Duplication

@mgallien mgallien added this to the 3.6.0 milestone Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants