Prevent crashing when trying to create error-ing QML component in systray.cpp, output error to log #4850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4850 +/- ##
=======================================
Coverage 57.21% 57.21%
=======================================
Files 138 138
Lines 17144 17144
=======================================
Hits 9809 9809
Misses 7335 7335 |
camilasan
approved these changes
Aug 17, 2022
allexzander
approved these changes
Aug 17, 2022
…tray.cpp, output error to log Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
claucambra
force-pushed
the
bugfix/qml-error-logging-cpp
branch
from
0b2829d to
fc5e9db
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
AppImage file: Nextcloud-PR-4850-fc5e9db839cb07e3d3ab8c5837d9203106ad200d-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment if we try to create a QML component (such as the call notification dialog) in systray.cpp which has an error, the client crashes.
When we try to open the tray window, the client does not crash, but it always provides a generic and unhelpful "QQMLApplicationEngine failed to load component" error.
This PR fixes both of these issues by checking
QQmlComponents for errors before trying to create them, and logging the error message if there is one.Signed-off-by: Claudio Cambra claudio.cambra@gmail.com