Fix File Activities dialog not showing up.

[allexzander]

Signed-off-by: alex-z blackslayer4@gmail.com

Playing around with Systray by calling the following methods

Systray.forceWindowInit(dialog);
Systray.positionWindowAtScreenCenter(dialog);

leads to FileActivityDialog sometimes showing up and sometimes no, completely randomly.

I am not completely sure why this happens, but, removing those calls seems to fix the issue. The dialog shows up in the center of the screen without centering it.

UPDATE: I have added a second commit with an alternative solution.

The bug can be observed in a video:

file_activities_dialog_won.t_show_up.mp4

[claucambra]

This breaks window positioning on some OSes (like macOS)

The window appears under the system tray window and also behind other windows

[allexzander]

@claucambra Any ideas on how to fix it alternatively, such that we don't have a bug of this dialog not showing up until manually opening the Systray as it happens now on Windows?

[allexzander]

@claucambra I've added a video demonstration to the description

[codecov]

Codecov Report

Merging #4867 (810ee9e) into master (2e2ed97) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 810ee9e differs from pull request most recent head ba9a398. Consider uploading reports for the commit ba9a398 to get more accurate results

@@            Coverage Diff             @@
##           master    #4867      +/-   ##
==========================================
- Coverage   57.23%   57.21%   -0.02%     
==========================================
  Files         138      138              
  Lines       17144    17144              
==========================================
- Hits         9812     9809       -3     
- Misses       7332     7335       +3     

Impacted Files	Coverage Δ
src/libsync/discovery.cpp	84.56% <0.00%> (-0.30%)	⬇️

[claucambra]

@claucambra Any ideas on how to fix it alternatively, such that we don't have a bug of this dialog not showing up until manually opening the Systray as it happens now on Windows?

It is almost certain that the issue is with forceWindowInit, specifically the Windows-only code in systray.cpp lines 431 and 432

I am not sure why this is an issue for the file activity dialog window and not for other windows (maybe those get a call to show again somewhere?) It does at least seem to be something straightforward to fix or work around

[allexzander]

@claucambra Any ideas on how to fix it alternatively, such that we don't have a bug of this dialog not showing up until manually opening the Systray as it happens now on Windows?

It is almost certain that the issue is with forceWindowInit, specifically the Windows-only code in systray.cpp lines 431 and 432

I am not sure why this is an issue for the file activity dialog window and not for other windows (maybe those get a call to show again somewhere?) It does at least seem to be something straightforward to fix or work around

Yes, I have tried fixing the show/hide code in CPP, and it didn't help. Now I have changed the order of calls in QML and it seems to have fixed the issue. Let me know your thoughts.

[nextcloud-desktop-bot]

AppImage file: Nextcloud-PR-4867-14ad0c9d41c6dae173963ecd794e6ffb5224fb53-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[claucambra]

This works fine on macOS and KDE :)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information