Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong estimated time when doing sync. #4902

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Fix wrong estimated time when doing sync. #4902

merged 1 commit into from
Sep 7, 2022

Conversation

allexzander
Copy link
Contributor

@allexzander allexzander commented Sep 6, 2022 •
edited
Loading

Signed-off-by: alex-z blackslayer4@gmail.com

This will fix #4891

@allexzander allexzander marked this pull request as ready for review September 6, 2022 12:58
@codecov
Copy link

codecov bot commented Sep 6, 2022 •
edited
Loading

Codecov Report

Merging #4902 (1010b63) into master (4dbbcbe) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 1010b63 differs from pull request most recent head 7ba6815. Consider uploading reports for the commit 7ba6815 to get more accurate results

@@            Coverage Diff             @@
##           master    #4902      +/-   ##
==========================================
+ Coverage   57.17%   57.20%   +0.02%     
==========================================
  Files         138      138              
  Lines       17133    17133              
==========================================
+ Hits         9796     9801       +5     
+ Misses       7337     7332       -5
Impacted Files Coverage Δ
src/libsync/propagatedownload.cpp 65.33% <0.00%> (+0.29%) ⬆️
src/libsync/discovery.cpp 84.86% <0.00%> (+0.29%) ⬆️

mgallien
mgallien requested changes Sep 7, 2022
View reviewed changes
src/gui/folderstatusmodel.h Outdated Show resolved Hide resolved
@allexzander
Fix wrong estimated time when doing sync.
7ba6815 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the bugfix/wrong-estimated-time-when-syncing branch from 1010b63 to 7ba6815 Compare September 7, 2022 06:31
@allexzander allexzander requested a review from mgallien September 7, 2022 06:31
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4902-7ba681544c91400665193cf135e2ee3925021727-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@allexzander allexzander merged commit 66effe1 into master Sep 7, 2022
@allexzander allexzander deleted the bugfix/wrong-estimated-time-when-syncing branch September 7, 2022 08:17
@mgallien mgallien added this to the 3.7.0 milestone Sep 7, 2022
@mgallien
Copy link
Collaborator

mgallien commented Sep 7, 2022

/backport to stable-3.6

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 7, 2022
Merged
@joshtrichards joshtrichards mentioned this pull request Aug 22, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@claucambra claucambra Awaiting requested review from claucambra

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.

[Bug]: wrong estimated time shown when doing sync
3 participants
@allexzander @nextcloud-desktop-bot @mgallien