Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.6] Bugfix/selective sync abort error #4908

Merged
merged 3 commits into from
Sep 12, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #4903

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #4908 (78a2ea3) into stable-3.6 (11bc4b5) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

@@              Coverage Diff               @@
##           stable-3.6    #4908      +/-   ##
==============================================
- Coverage       57.22%   57.21%   -0.02%     
==============================================
  Files             138      138              
  Lines           17134    17136       +2     
==============================================
- Hits             9805     9804       -1     
- Misses           7329     7332       +3     
Impacted Files Coverage Δ
src/libsync/syncengine.cpp 87.20% <50.00%> (-0.03%) ⬇️
src/libsync/owncloudpropagator.cpp 86.02% <100.00%> (+0.02%) ⬆️
src/libsync/owncloudpropagator.h 74.43% <100.00%> (+1.15%) ⬆️
src/libsync/propagateuploadng.cpp 82.39% <0.00%> (-1.50%) ⬇️
src/libsync/propagateremotemkdir.cpp 64.53% <0.00%> (-0.71%) ⬇️
src/libsync/propagatedownload.cpp 65.03% <0.00%> (-0.30%) ⬇️
src/libsync/discovery.cpp 84.86% <0.00%> (+0.29%) ⬆️

…not displayed in UI.

Signed-off-by: alex-z <blackslayer4@gmail.com>
Signed-off-by: alex-z <blackslayer4@gmail.com>
…ync.

Signed-off-by: allexzander <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the backport/4903/stable-3.6 branch from 51b4221 to 78a2ea3 Compare September 12, 2022 08:01
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

26.7% 26.7% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4908-78a2ea3ee91cfbfc5b834ca1e790047c596a5cc2-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander merged commit b9d14fa into stable-3.6 Sep 12, 2022
@allexzander allexzander deleted the backport/4903/stable-3.6 branch September 12, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants