-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MacOS UTF-8 normalization issue #4957
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4957 +/- ##
==========================================
- Coverage 59.28% 57.12% -2.17%
==========================================
Files 143 138 -5
Lines 18445 17234 -1211
==========================================
- Hits 10936 9845 -1091
+ Misses 7509 7389 -120
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
This looks fine to me though why not implement this for all systems as a precautionary measure?
Would like to get your feedback before merging @mgallien @allexzander @camilasan
@xavi-b thanks for your contribution why do even need to use such a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgallien Say we merge this for now, and get ride of hash down the road?
Signed-off-by: xavi-b <developer@xavi-b.fr>
AppImage file: nextcloud-PR-4957-5113802daf38afdf5934fcd210e74513b22decd8-x86_64.AppImage |
/backport to stable-3.8 |
Fix #4950