Improve the error box QML component

[claucambra]

Makes it less strident and easier to read

versus before:

Code also includes a close button we will be using for #4929 to dismiss the error box

Closes #4946

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

[jancborchardt]

Much better. Best regards, my eyes 👀

[mgallien]

is there a way we could get the proper error color from the server theming API ?

[claucambra]

is there a way we could get the proper error color from the server theming API ?

Possibly, I will investigate the capabilities API

I will merge this and if we can pull the error colour from the capabilities then I will open a new PR using that

[codecov]

Codecov Report

Merging #4976 (9781e89) into master (0d8a70e) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4976      +/-   ##
==========================================
+ Coverage   57.11%   57.13%   +0.01%     
==========================================
  Files         138      138              
  Lines       17230    17221       -9     
==========================================
- Hits         9841     9839       -2     
+ Misses       7389     7382       -7     

Impacted Files	Coverage Δ
src/libsync/theme.cpp	12.90% <ø> (+0.23%)	⬆️
src/libsync/theme.h	33.33% <ø> (ø)
src/common/utility_win.cpp	42.98% <0.00%> (-0.46%)	⬇️
src/libsync/propagatedownload.cpp	64.61% <0.00%> (-0.15%)	⬇️

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-4976-9781e896a16089d8eb98365914f48b65631cefb9-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.