Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix predefined status text formatting #4987

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

claucambra
Copy link
Collaborator

With recent changes to text formatting being set to plain text rather than rich HTML text, some of the internal styling used for predefined status messages has broken. This PR fixes it.

With fix:

Screenshot 2022-09-29 at 19 38 12

Before fix:

Screenshot 2022-09-29 at 19 38 52

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #4987 (652c0dc) into master (d740578) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4987      +/-   ##
==========================================
- Coverage   57.13%   57.13%   -0.01%     
==========================================
  Files         138      138              
  Lines       17221    17221              
==========================================
- Hits         9840     9839       -1     
- Misses       7381     7382       +1     
Impacted Files Coverage Δ
src/libsync/propagatedownload.cpp 64.61% <0.00%> (-0.15%) ⬇️

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@mgallien mgallien force-pushed the bugfix/fix-predefined-status-text branch from d47ccc1 to 652c0dc Compare September 30, 2022 14:24
@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4987-652c0dcff71f905f626606043a23b14d501fed0d-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit fc03d73 into master Sep 30, 2022
@claucambra claucambra deleted the bugfix/fix-predefined-status-text branch September 30, 2022 17:37
@mgallien mgallien added this to the 3.7.0 milestone Oct 3, 2022
@claucambra
Copy link
Collaborator Author

/backport to stable-3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants