Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let's check the format via some github action #4991

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

mgallien
Copy link
Collaborator

Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #4991 (6f7748b) into master (b9f6d91) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4991      +/-   ##
==========================================
+ Coverage   57.22%   57.24%   +0.02%     
==========================================
  Files         138      138              
  Lines       17359    17359              
==========================================
+ Hits         9933     9937       +4     
+ Misses       7426     7422       -4     
Impacted Files Coverage Δ
src/libsync/propagatedownload.cpp 64.61% <0.00%> (+0.14%) ⬆️
src/libsync/discovery.cpp 83.95% <0.00%> (+0.28%) ⬆️

@mgallien mgallien force-pushed the ci/checkFormatWithClangFormat branch from 3804821 to c516b00 Compare September 30, 2022 15:20
@mgallien mgallien force-pushed the ci/checkFormatWithClangFormat branch 5 times, most recently from d2eb2e2 to 6f7748b Compare October 4, 2022 12:10
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
takes it from current extra-cmake-modules repository

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the ci/checkFormatWithClangFormat branch from 6f7748b to 57e4053 Compare October 4, 2022 16:31
@mgallien mgallien merged commit af0764d into master Oct 4, 2022
@mgallien mgallien deleted the ci/checkFormatWithClangFormat branch October 4, 2022 16:32
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4991-57e405321634a7cf7b7720464b138828a7e4fbdd-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgallien mgallien added this to the 3.7.0 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants