Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/check clang tidy in ci #4995

Merged
merged 2 commits into from
Oct 2, 2022
Merged

Ci/check clang tidy in ci #4995

merged 2 commits into from
Oct 2, 2022

Conversation

mgallien
Copy link
Collaborator

No description provided.

@github-actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@mgallien mgallien force-pushed the ci/checkClangTidyInCi branch 4 times, most recently from 494c262 to 37c9be9 Compare September 30, 2022 20:22
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #4995 (554245f) into master (a7dcbad) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Current head 554245f differs from pull request most recent head 8862973. Consider uploading reports for the commit 8862973 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4995      +/-   ##
==========================================
- Coverage   57.13%   57.00%   -0.14%     
==========================================
  Files         138      138              
  Lines       17221    17221              
==========================================
- Hits         9840     9817      -23     
- Misses       7381     7404      +23     
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/hydrationjob.cpp 52.38% <0.00%> (-3.71%) ⬇️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 83.33% <0.00%> (-2.44%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 72.83% <0.00%> (-1.83%) ⬇️
src/libsync/syncengine.cpp 85.02% <0.00%> (-0.54%) ⬇️
src/libsync/propagatedownload.cpp 64.75% <0.00%> (+0.14%) ⬆️

@mgallien mgallien force-pushed the ci/checkClangTidyInCi branch 8 times, most recently from 9778ebf to 554245f Compare September 30, 2022 22:01
@mgallien mgallien force-pushed the ci/checkClangTidyInCi branch from 554245f to 65f2490 Compare October 2, 2022 12:43
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-auto' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the ci/checkClangTidyInCi branch 2 times, most recently from 540b294 to 60f33dd Compare October 2, 2022 13:06
should allow to keep our code tidy and maybe simplify reviews

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the ci/checkClangTidyInCi branch from 60f33dd to 8862973 Compare October 2, 2022 13:09
@mgallien mgallien merged commit bfe0b30 into master Oct 2, 2022
@mgallien mgallien deleted the ci/checkClangTidyInCi branch October 2, 2022 13:14
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4995-88629737c1c3d1105dc3b8183fc905af2e5ee6ca-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.7.0 milestone Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants