Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.6] Bring back .lnk files on Windows and always treat them as non-virtual files. #5000

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #4968

… files.

Signed-off-by: alex-z <blackslayer4@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5000-f141b3d2d03b8149acb8612705c092be9252606f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #5000 (f141b3d) into stable-3.6 (2ae7698) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

Additional details and impacted files
@@              Coverage Diff               @@
##           stable-3.6    #5000      +/-   ##
==============================================
- Coverage       57.20%   57.19%   -0.02%     
==============================================
  Files             138      138              
  Lines           17155    17153       -2     
==============================================
- Hits             9814     9811       -3     
- Misses           7341     7342       +1     
Impacted Files Coverage Δ
src/csync/vio/csync_vio_local_win.cpp 81.39% <ø> (-0.43%) ⬇️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 85.77% <33.33%> (-0.65%) ⬇️
src/libsync/discovery.cpp 84.57% <100.00%> (+0.24%) ⬆️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.20% <0.00%> (-0.46%) ⬇️

@allexzander allexzander merged commit 8d3ea85 into stable-3.6 Oct 3, 2022
@allexzander allexzander deleted the backport/4968/stable-3.6 branch October 3, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants