Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve logs when adding sync errors in activity list of main dialog #5032

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

mgallien
Copy link
Collaborator

Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/improveSyncLogs branch from 23733dd to ec1fb62 Compare October 12, 2022 06:25
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5032-ec1fb6209a9fe93b94998f3eec33f0b91a361d8f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #5032 (ec1fb62) into master (bde2f90) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5032      +/-   ##
==========================================
- Coverage   57.34%   57.30%   -0.04%     
==========================================
  Files         138      138              
  Lines       17391    17391              
==========================================
- Hits         9972     9966       -6     
- Misses       7419     7425       +6     
Impacted Files Coverage Δ
src/libsync/propagatedownload.cpp 63.43% <0.00%> (-1.18%) ⬇️
src/libsync/propagatorjobs.cpp 73.23% <0.00%> (+1.40%) ⬆️

@mgallien mgallien merged commit 002b5ee into master Oct 12, 2022
@mgallien mgallien deleted the bugfix/improveSyncLogs branch October 12, 2022 07:48
@mgallien mgallien added this to the 3.7.0 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants