Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.6] Fix link shares default expire date being enforced as maximum expire date even when maximum date enforcement is disabled on the server #5048

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #4982

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #5048 (d8649e6) into stable-3.6 (1f5498c) will not change coverage.
The diff coverage is n/a.

❗ Current head d8649e6 differs from pull request most recent head a834ac6. Consider uploading reports for the commit a834ac6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           stable-3.6    #5048   +/-   ##
===========================================
  Coverage       57.17%   57.17%           
===========================================
  Files             138      138           
  Lines           17160    17160           
===========================================
  Hits             9812     9812           
  Misses           7348     7348           
Impacted Files Coverage Δ
src/libsync/propagateremotedelete.cpp 54.90% <0.00%> (-1.10%) ⬇️
src/libsync/propagateremotemkdir.cpp 64.53% <0.00%> (-0.71%) ⬇️
src/libsync/propagateremotemove.cpp 81.65% <0.00%> (-0.49%) ⬇️
src/libsync/syncengine.cpp 86.72% <0.00%> (-0.48%) ⬇️
src/libsync/discoveryphase.cpp 72.34% <0.00%> (-0.21%) ⬇️
src/libsync/account.cpp 38.22% <0.00%> (-0.16%) ⬇️
src/libsync/propagatedownload.cpp 65.13% <0.00%> (-0.06%) ⬇️
src/libsync/discovery.cpp 84.33% <0.00%> (+0.05%) ⬆️
src/libsync/propagateuploadv1.cpp 69.44% <0.00%> (+0.17%) ⬆️
src/libsync/bandwidthmanager.cpp 38.78% <0.00%> (+0.18%) ⬆️
... and 3 more

@claucambra
Copy link
Collaborator

/rebase

…date even when maximum date enforcement is disabled on the server

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5048-a834ac6d1635ebec0804a23d010dc89473177247-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit 616c85f into stable-3.6 Oct 18, 2022
@claucambra claucambra deleted the backport/4982/stable-3.6 branch October 18, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants