Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/4989/stable 3.6 #5052

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Backport/4989/stable 3.6 #5052

merged 3 commits into from
Oct 18, 2022

Conversation

camilasan
Copy link
Member

backport of #4989

I had to do it by hand, the backport bot reported conflicts that did not exist...

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #5052 (7d296ad) into stable-3.6 (1f5498c) will not change coverage.
The diff coverage is n/a.

❗ Current head 7d296ad differs from pull request most recent head 87509de. Consider uploading reports for the commit 87509de to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           stable-3.6    #5052   +/-   ##
===========================================
  Coverage       57.17%   57.17%           
===========================================
  Files             138      138           
  Lines           17160    17160           
===========================================
  Hits             9812     9812           
  Misses           7348     7348           
Impacted Files Coverage Δ
src/libsync/propagateremotemkdir.cpp 64.53% <0.00%> (-0.71%) ⬇️
src/libsync/propagatedownload.cpp 65.03% <0.00%> (-0.15%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.65% <0.00%> (+0.45%) ⬆️

Camila added 3 commits October 18, 2022 11:42
Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
@mgallien mgallien force-pushed the backport/4989/stable-3.6 branch from 7d296ad to 87509de Compare October 18, 2022 09:42
@mgallien mgallien merged commit 0843676 into stable-3.6 Oct 18, 2022
@mgallien mgallien deleted the backport/4989/stable-3.6 branch October 18, 2022 09:50
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5052-87509de0b4619fc83fadc66e1af49a1b699cc714-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.6.1 milestone Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants