Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix account not found when doing local file editing. #5056

Merged
merged 1 commit into from
Oct 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/gui/application.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,7 @@ void Application::handleEditLocally(const QUrl &url) const
}

// for a sample URL "nc://open/admin@nextcloud.lan:8080/Photos/lovely.jpg", QUrl::path would return "admin@nextcloud.lan:8080/Photos/lovely.jpg"
const auto accountDisplayName = pathSplit.takeFirst();
const auto userId = pathSplit.takeFirst();
const auto fileRemotePath = pathSplit.join('/');
const auto urlQuery = QUrlQuery{url};

Expand All @@ -774,7 +774,7 @@ void Application::handleEditLocally(const QUrl &url) const
qCWarning(lcApplication) << "Invalid URL for file local editing: missing token";
}

FolderMan::instance()->editFileLocally(accountDisplayName, fileRemotePath, token);
FolderMan::instance()->editFileLocally(userId, fileRemotePath, token);
}

QString substLang(const QString &lang)
Expand Down
22 changes: 17 additions & 5 deletions src/gui/folderman.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1422,7 +1422,7 @@ void FolderMan::setDirtyNetworkLimits()
}
}

void FolderMan::editFileLocally(const QString &accountDisplayName, const QString &relPath, const QString &token)
void FolderMan::editFileLocally(const QString &userId, const QString &relPath, const QString &token)
{
const auto showError = [this](const OCC::AccountStatePtr accountState, const QString &errorMessage, const QString &subject) {
if (accountState && accountState->account()) {
Expand All @@ -1449,15 +1449,27 @@ void FolderMan::editFileLocally(const QString &accountDisplayName, const QString

if (token.isEmpty()) {
qCWarning(lcFolderMan) << "Edit locally request is missing a valid token. Impossible to open the file.";
showError({}, tr("Edit locally request is not valid. Opening the file is forbidden."), accountDisplayName);
showError({}, tr("Edit locally request is not valid. Opening the file is forbidden."), userId);
return;
}

const auto accountFound = AccountManager::instance()->account(accountDisplayName);
const auto accountFound = [&userId]() {
for (const auto &account : AccountManager::instance()->accounts()) {
const auto isUserIdWithPort = userId.split(QLatin1Char(':')).size() > 1;
const auto port = isUserIdWithPort ? account->account()->url().port() : -1;
const auto portString = (port > 0 && port != 80 && port != 443) ? QStringLiteral(":%1").arg(port) : QStringLiteral("");
const QString davUserId = QStringLiteral("%1@%2").arg(account->account()->davUser(), account->account()->url().host()) + portString;

if (davUserId == userId) {
return account;
}
}
return AccountStatePtr{};
}();

if (!accountFound) {
qCWarning(lcFolderMan) << "Could not find an account " << accountDisplayName << " to edit file " << relPath << " locally.";
showError(accountFound, tr("Could not find an account for local editing"), accountDisplayName);
qCWarning(lcFolderMan) << "Could not find an account " << userId << " to edit file " << relPath << " locally.";
showError(accountFound, tr("Could not find an account for local editing"), userId);
return;
}

Expand Down
2 changes: 1 addition & 1 deletion src/gui/folderman.h
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ class FolderMan : public QObject
void setDirtyNetworkLimits();

/** opens a file with default app, if the file is present **/
void editFileLocally(const QString &accountDisplayName, const QString &relPath, const QString &token);
void editFileLocally(const QString &userId, const QString &relPath, const QString &token);

signals:
/**
Expand Down