Bugfix/delete folders during propagation even when propagation has errors #5104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allexzander
reviewed
Oct 29, 2022
allexzander
reviewed
Oct 29, 2022
|
@mgallien What exactly the issue is and how I can reproduce it? |
mgallien
changed the title
mgallien
changed the title
mgallien
force-pushed
the
bugfix/doNotDeleteFilesInSyncDatabase
branch
2 times, most recently
from
9ca10b1 to
518be9d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5104 +/- ##
==========================================
+ Coverage 57.39% 57.40% +0.01%
==========================================
Files 138 138
Lines 17444 17444
==========================================
+ Hits 10012 10014 +2
+ Misses 7432 7430 -2
|
allexzander
approved these changes
Oct 31, 2022
|
@mgallien Please clean-up the history |
allexzander
force-pushed
the
bugfix/doNotDeleteFilesInSyncDatabase
branch
2 times, most recently
from
64f1ba5 to
684d39d
Compare
mgallien
force-pushed
the
bugfix/doNotDeleteFilesInSyncDatabase
branch
from
684d39d to
f150643
Compare
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
use nextcloud namespace for discovery logs as it does not show correcly without that this is because we have central rules for all logs from nextcloud namespace Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
in case some propgation actions ends up with a BlacklistedError, we would skip the deletions of local folders (even though they have been deleted from server) let's not skip them but rather keep track of the error status and properly report them Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/doNotDeleteFilesInSyncDatabase
branch
from
f150643 to
402d959
Compare
|
SonarCloud Quality Gate failed. |
|
AppImage file: nextcloud-PR-5104-402d959caea89c461366a232e807dced2c712034-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not skip folders to delete in case of errors with blacklisted files
clean up and log improvements