Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with newer python3-nautilus #5105

Merged
merged 1 commit into from
Oct 29, 2022
Merged

Fix compatibility with newer python3-nautilus #5105

merged 1 commit into from
Oct 29, 2022

Conversation

nteodosio
Copy link
Contributor

Resurrecting #4870.

claucambra
claucambra approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reopening! Looks good to me :)

@codecov
Copy link

codecov bot commented Oct 28, 2022 •
edited
Loading

Codecov Report

Merging #5105 (1375f0c) into master (76c4e06) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 1375f0c differs from pull request most recent head 2ba0820. Consider uploading reports for the commit 2ba0820 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5105      +/-   ##
==========================================
+ Coverage   57.17%   57.22%   +0.04%     
==========================================
  Files         138      138              
  Lines       17441    17441              
==========================================
+ Hits         9972     9980       +8     
+ Misses       7469     7461       -8
Impacted Files Coverage Δ
src/libsync/propagatedownload.cpp 64.61% <0.00%> (+1.17%) ⬆️

@nteodosio @claucambra
Fix compatibility with newer python3-nautilus
2ba0820 
Signed-off-by: Nathan Pratta Teodosio <nathan.teodosio@canonical.com>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5105-2ba08206af799acba76fd93fed50cbdba798d498-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit 6f67c2e into nextcloud:master Oct 29, 2022
@claucambra
Copy link
Collaborator

/backport to stable-3.6

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 29, 2022
Merged
@mgallien mgallien added this to the 3.7.0 milestone Nov 8, 2022
@celticmagic celticmagic mentioned this pull request Aug 16, 2023
Closed
5 tasks
@laedit laedit mentioned this pull request Aug 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

Assignees
No one assigned
Labels
backport-request
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nteodosio @nextcloud-desktop-bot @claucambra @mgallien