Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.6] Validate and sanitise edit locally token and relpath before sending to server #5106

Merged
merged 4 commits into from
Oct 28, 2022
Merged

[stable-3.6] Validate and sanitise edit locally token and relpath before sending to server #5106

merged 4 commits into from
Oct 28, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #5093

@claucambra @backportbot-nextcloud
Validate edit locally token before sending to server
c0cf965 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot-nextcloud
Make sure to encode the relPath
e8f62f3 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot-nextcloud
Make sure to check relPath and compare to canonical cleaned path
1806113 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot-nextcloud
Use addQueryParams for checkTokenForEditLocally SimpleApiJob
67ecebf 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.6.2 milestone Oct 28, 2022
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5106-67ecebf4f63783ddf7e5db401d2a8096f541c407-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #5106 (67ecebf) into stable-3.6 (f4a3e1d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files 
@@              Coverage Diff               @@
##           stable-3.6    #5106      +/-   ##
==============================================
- Coverage       57.17%   57.16%   -0.01%     
==============================================
  Files             138      138              
  Lines           17187    17187              
==============================================
- Hits             9826     9825       -1     
- Misses           7361     7362       +1
Impacted Files Coverage Δ
src/libsync/propagatedownload.cpp 65.03% <0.00%> (-0.15%) ⬇️

@claucambra claucambra merged commit 6fa2e60 into stable-3.6 Oct 28, 2022
@claucambra claucambra deleted the backport/5093/stable-3.6 branch October 28, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@allexzander allexzander Awaiting requested review from allexzander

@camilasan camilasan Awaiting requested review from camilasan

@mgallien mgallien Awaiting requested review from mgallien

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@nextcloud-desktop-bot @claucambra