Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.6] use new public API to open an edit locally URL #5117

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #5116

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #5117 (1b62b01) into stable-3.6 (a1c565a) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 1b62b01 differs from pull request most recent head fe5909d. Consider uploading reports for the commit fe5909d to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           stable-3.6    #5117      +/-   ##
==============================================
- Coverage       57.18%   57.17%   -0.02%     
==============================================
  Files             138      138              
  Lines           17187    17187              
==============================================
- Hits             9828     9826       -2     
- Misses           7359     7361       +2     
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.20% <0.00%> (-0.46%) ⬇️

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the backport/5116/stable-3.6 branch from 1b62b01 to fe5909d Compare October 31, 2022 13:58
@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5117-fe5909d5e4628d9d327f4dc8b1e54c021917b4b5-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit ddeee8e into stable-3.6 Oct 31, 2022
@mgallien mgallien deleted the backport/5116/stable-3.6 branch October 31, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants