Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly escape a path when creating a test file during tests #5151

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Nov 9, 2022

Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com

@mgallien
Copy link
Collaborator Author

mgallien commented Nov 9, 2022

/backport to stable-3.6

@mgallien mgallien force-pushed the ci/fixOneTestOnWindows branch from 8b3678c to ceffee9 Compare November 9, 2022 16:48
@mgallien mgallien requested a review from claucambra November 9, 2022 16:55
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #5151 (7dfb27f) into master (ae6cd7c) will decrease coverage by 0.14%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5151      +/-   ##
==========================================
- Coverage   57.71%   57.56%   -0.15%     
==========================================
  Files         138      138              
  Lines       17399    17399              
==========================================
- Hits        10042    10016      -26     
- Misses       7357     7383      +26     
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/hydrationjob.cpp 52.38% <0.00%> (-3.71%) ⬇️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 83.00% <0.00%> (-2.38%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 72.50% <0.00%> (-1.60%) ⬇️
src/libsync/syncengine.cpp 83.71% <0.00%> (-0.46%) ⬇️
src/libsync/discovery.cpp 88.03% <0.00%> (-0.31%) ⬇️

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the ci/fixOneTestOnWindows branch from ceffee9 to 7dfb27f Compare November 9, 2022 17:35
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5151-7dfb27f7995193ba6738f11b88a809aaa9911095-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgallien mgallien merged commit 83c3746 into master Nov 9, 2022
@mgallien mgallien deleted the ci/fixOneTestOnWindows branch November 9, 2022 21:49
@mgallien mgallien added this to the 3.7.0 milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants