Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearly tell user that E2EE has been enabled for an account #5164

Merged
merged 7 commits into from
Nov 25, 2022

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Nov 10, 2022

Screenshot 2022-11-15 at 12 26 51

Screenshot 2022-11-15 at 12 26 54

Part of #5126

Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #5164 (201cd4d) into master (ab8f0db) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head 201cd4d differs from pull request most recent head 2459a3a. Consider uploading reports for the commit 2459a3a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5164      +/-   ##
==========================================
- Coverage   57.80%   57.65%   -0.15%     
==========================================
  Files         138      138              
  Lines       17441    17399      -42     
==========================================
- Hits        10082    10032      -50     
- Misses       7359     7367       +8     
Impacted Files Coverage Δ
src/libsync/theme.h 33.33% <ø> (ø)
src/libsync/syncfileitem.cpp 94.91% <0.00%> (-3.39%) ⬇️
src/libsync/propagatorjobs.cpp 71.83% <0.00%> (-3.17%) ⬇️
src/libsync/discovery.h 57.14% <0.00%> (-2.12%) ⬇️
src/libsync/filesystem.cpp 73.11% <0.00%> (-1.08%) ⬇️
src/common/syncjournaldb.cpp 77.63% <0.00%> (-0.30%) ⬇️
src/libsync/discovery.cpp 88.03% <0.00%> (-0.22%) ⬇️
src/libsync/discoveryphase.h 25.00% <0.00%> (ø)
src/libsync/propagatorjobs.h 0.00% <0.00%> (ø)
src/libsync/syncengine.cpp 84.16% <0.00%> (+0.37%) ⬆️

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :) Just the icons are a bit off:

  • The checkmark icon shouldnt be the "All synced" icon
  • The info icon looks a bit oldish

Similar like for "General" and "Network", could we use native icons for each of them which work for the platform?

Otherwise as quick fixes:

src/gui/accountsettings.cpp Outdated Show resolved Hide resolved
src/gui/accountsettings.cpp Outdated Show resolved Hide resolved
@claucambra
Copy link
Collaborator Author

Nice! :) Just the icons are a bit off:

  • The checkmark icon shouldnt be the "All synced" icon
  • The info icon looks a bit oldish

Similar like for "General" and "Network", could we use native icons for each of them which work for the platform?

Otherwise as quick fixes:

Okay, I have changed the icons used in the message box and updated the screenshots above 🙂

Ad for native icons more generally, let's open a separate issue for this

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! :)

@tobiasKaminsky
Copy link
Member

Not sure if it is still valid, but in second screenshot:
I assume that account has no E2E yet, so button might better be "setup" instead of "enable e2e" to distinguish this more.

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5164-201cd4d0d34146642693b64c230c1e2d4cc0bfff-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra
Copy link
Collaborator Author

Not sure if it is still valid, but in second screenshot:
I assume that account has no E2E yet, so button might better be "setup" instead of "enable e2e" to distinguish this more.

changed :)

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5164-2459a3a9f39f0bba9c15d2fbb97317a0009c1069-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit 39876c4 into master Nov 25, 2022
@claucambra claucambra deleted the feature/e2ee-wording branch November 25, 2022 13:10
@mgallien mgallien added this to the 3.7.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants