-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearly tell user that E2EE has been enabled for an account #5164
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5164 +/- ##
==========================================
- Coverage 57.80% 57.65% -0.15%
==========================================
Files 138 138
Lines 17441 17399 -42
==========================================
- Hits 10082 10032 -50
- Misses 7359 7367 +8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! :) Just the icons are a bit off:
- The checkmark icon shouldnt be the "All synced" icon
- The info icon looks a bit oldish
Similar like for "General" and "Network", could we use native icons for each of them which work for the platform?
Otherwise as quick fixes:
- E2E active, a lock: https://fonts.google.com/icons?selected=Material%20Icons%3Alock%3A
- E2E possible, info i: https://fonts.google.com/icons?selected=Material%20Icons%3Ainfo%3A
Okay, I have changed the icons used in the message box and updated the screenshots above 🙂 Ad for native icons more generally, let's open a separate issue for this |
763823c
to
2c4a80f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice! :)
Not sure if it is still valid, but in second screenshot: |
AppImage file: nextcloud-PR-5164-201cd4d0d34146642693b64c230c1e2d4cc0bfff-x86_64.AppImage |
changed :) |
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
201cd4d
to
2459a3a
Compare
SonarCloud Quality Gate failed. |
AppImage file: nextcloud-PR-5164-2459a3a9f39f0bba9c15d2fbb97317a0009c1069-x86_64.AppImage |
Part of #5126
Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com