Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check that we update local file mtime on changes from server #5188

Merged
merged 5 commits into from
Nov 22, 2022
Merged

check that we update local file mtime on changes from server #5188

merged 5 commits into from
Nov 22, 2022

Conversation

mgallien
Copy link
Collaborator

Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com

@mgallien mgallien mentioned this pull request Nov 18, 2022
Closed
@mgallien mgallien changed the title check that we update local fime mtime on changes from server check that we update local file mtime on changes from server Nov 21, 2022
@mgallien mgallien force-pushed the bugfix/properlyUpdateMetadata branch 2 times, most recently from 9939709 to 0539fc6 Compare November 22, 2022 09:54
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@mgallien
check that we update local file mtime on changes from server
c379879 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
update mtime on modified metdata of non virtual files
1af2467 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
set mtime when building local sync folder state in automated tests
b04128f 
would allow checking mtime with a correct value instead of having a
default value

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
when renaming a virtual file, manage pin state for the target name
a00ec1a 
will avoid trying to set a pin state for a file that has just been
renamed by us

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
fix many errors when querying/setting pin state of virtual files
361db77 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/properlyUpdateMetadata branch from 0539fc6 to 361db77 Compare November 22, 2022 14:45
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5188-361db77d3ccc262e88925842781893fe83dc8e5d-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 6d5db8f into master Nov 22, 2022
@mgallien mgallien deleted the bugfix/properlyUpdateMetadata branch November 22, 2022 17:24
@mgallien mgallien added this to the 3.7.0 milestone Nov 24, 2022
@Bockeman
Copy link

Bockeman commented Nov 26, 2022 •
edited
Loading

Early indications suggest this fix might have a negative impact on
#2467 (comment)
but because of the random nature of false conflicts no positive conclusion can be formed.

@mgallien mgallien mentioned this pull request Dec 7, 2022
Closed
8 tasks
@mgallien
Copy link
Collaborator Author

/backport to stable-3.6

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mgallien @nextcloud-desktop-bot @Bockeman @claucambra