Use QFileInfo::exists where we are only creating a QFileInfo to check if file exists

[claucambra]

QFileInfo::exists is faster

Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com

[codecov]

Codecov Report

Merging #5291 (3bbd1d6) into master (7f6b18b) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 3bbd1d6 differs from pull request most recent head f6c4c32. Consider uploading reports for the commit f6c4c32 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5291      +/-   ##
==========================================
- Coverage   57.59%   57.52%   -0.08%     
==========================================
  Files         139      139              
  Lines       17596    17596              
==========================================
- Hits        10135    10122      -13     
- Misses       7461     7474      +13     

Impacted Files	Coverage Δ
src/libsync/syncengine.cpp	81.32% <100.00%> (-0.44%)	⬇️
src/libsync/vfs/cfapi/hydrationjob.cpp	52.38% <0.00%> (-3.71%)	⬇️
src/libsync/vfs/cfapi/vfs_cfapi.cpp	83.07% <0.00%> (-2.37%)	⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp	72.50% <0.00%> (-1.82%)	⬇️
src/libsync/discovery.cpp	86.22% <0.00%> (+0.28%)	⬆️
src/libsync/propagatedownload.cpp	64.90% <0.00%> (+1.17%)	⬆️

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-5291-f6c4c32b6e25948c8782ca08f27d6285ca1ee796-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

20.0% Coverage
0.0% Duplication