Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.6] Drop dependency on Qt Quick Controls 1 #5312

Merged
merged 1 commit into from
Jan 6, 2023
Merged

[stable-3.6] Drop dependency on Qt Quick Controls 1 #5312

merged 1 commit into from
Jan 6, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #5309

@Flowdalic @backportbot-nextcloud
Drop dependency on Qt Quick Controls 1
57f0f59 
Qt Quick Controls 1 where deprecated with Qt 5.11 [1]. Nextcloud still
depends on Quick Controls 1 by importing QtQuick.Dialogs. Removing
those imports will cause the QMl script to use the according API from
Quick Controls 2, which are, fortunately largely API-comptible.

This helps distribution to deprecate and remove Quick Controls 1 [2].

1: https://doc.qt.io/qt-6/qtquickcontrols-changes-qt6.html#migrating-from-qt-quick-controls-1
2: https://bugs.gentoo.org/889772

Signed-off-by: Florian Schmaus <flo@geekplace.eu>
@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.6.5 milestone Jan 6, 2023
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5312-57f0f591536f9d8e99e39542335a83df1f03353a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit b9fb939 into stable-3.6 Jan 6, 2023
@claucambra claucambra deleted the backport/5309/stable-3.6 branch January 6, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.5
Development

Successfully merging this pull request may close these issues.
3 participants
@nextcloud-desktop-bot @claucambra @Flowdalic