-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/secure file drop #5327
Feature/secure file drop #5327
Conversation
@tobiasKaminsky The reason for me closing this is that I am in an intermediate step right now and don't want anyone to use a non-working version. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5327 +/- ##
==========================================
+ Coverage 57.84% 58.86% +1.01%
==========================================
Files 141 143 +2
Lines 18149 18312 +163
==========================================
+ Hits 10498 10779 +281
+ Misses 7651 7533 -118
|
f10af82
to
97720ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a ton of comments, and mostly small ones
9769a52
to
c205eb5
Compare
ca563db
to
6380275
Compare
6380275
to
d7325b2
Compare
fb2e649
to
cb3ff79
Compare
df448fd
to
01de752
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add automated tests especially for the new job class UpdateFileDropMetadata
01de752
to
4652d8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
No clang-tidy warnings found so I assume my comments were addressed
0006522
to
7d637e5
Compare
qCDebug(lcUpdateFileDropMetadataJob) << "Metadata Received, Preparing it for the new file." << json.toVariant(); | ||
|
||
// Encrypt File! | ||
_metadata = new FolderMetadata(propagator()->account(), json.toJson(QJsonDocument::Compact), statusCode); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex ?
030f80a
to
59686c8
Compare
…iles' when syncing E2EE folders. Signed-off-by: alex-z <blackslayer4@gmail.com>
59686c8
to
b6ba1fe
Compare
AppImage file: nextcloud-PR-5327-b6ba1fe0d61326d24b7c3700531f1a32db6736da-x86_64.AppImage |
SonarCloud Quality Gate failed. |
No description provided.