Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log to stdout when built in Debug config #5410

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Feb 7, 2023

Having to sift through the log files can be a pain, so it makes sense to log to stdout as normal when we build in debug mode

With this we can check logging directly in Qt Creator or in the terminal

@claucambra claucambra self-assigned this Feb 7, 2023
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #5410 (4d9fef8) into master (7953d4e) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5410   +/-   ##
=======================================
  Coverage   57.96%   57.97%           
=======================================
  Files         141      141           
  Lines       18133    18133           
=======================================
+ Hits        10511    10512    +1     
+ Misses       7622     7621    -1     
Impacted Files Coverage Δ
src/libsync/logger.cpp 27.90% <50.00%> (ø)
src/libsync/vfs/cfapi/cfapiwrapper.cpp 73.18% <0.00%> (+0.22%) ⬆️

@claucambra claucambra force-pushed the feature/terminal-logging branch 2 times, most recently from bd1f567 to ffa59e9 Compare February 8, 2023 20:35
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the feature/terminal-logging branch from ffa59e9 to 4d9fef8 Compare February 13, 2023 18:59
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5410-4d9fef81c949289c0159a969a45e420f516f475f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@claucambra claucambra merged commit 7da0c2c into master Feb 13, 2023
@claucambra claucambra deleted the feature/terminal-logging branch February 13, 2023 19:47
@mgallien mgallien added this to the 3.8.0 milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants