Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n: Added dot to end of sentence #5427

Merged
merged 1 commit into from
Feb 21, 2023
Merged

l10n: Added dot to end of sentence #5427

merged 1 commit into from
Feb 21, 2023

Conversation

rakekniven
Copy link
Member

Aligned end of sentences in about dialog.

Signed-off-by: rakekniven 2069590+rakekniven@users.noreply.github.com

src/libsync/theme.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #5427 (774780d) into master (7ef5ca8) will increase coverage by 0.14%.
The diff coverage is 0.00%.

❗ Current head 774780d differs from pull request most recent head c195513. Consider uploading reports for the commit c195513 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5427      +/-   ##
==========================================
+ Coverage   57.82%   57.96%   +0.14%     
==========================================
  Files         141      141              
  Lines       18146    18133      -13     
==========================================
+ Hits        10493    10511      +18     
+ Misses       7653     7622      -31     
Impacted Files Coverage Δ
src/libsync/theme.cpp 16.88% <0.00%> (ø)
src/libsync/logger.cpp 27.90% <0.00%> (ø)
src/libsync/clientsideencryption.h 30.76% <0.00%> (ø)
src/libsync/account.cpp 36.26% <0.00%> (+0.06%) ⬆️
src/libsync/clientsideencryption.cpp 26.84% <0.00%> (+0.84%) ⬆️
src/libsync/creds/abstractcredentials.cpp 71.42% <0.00%> (+57.14%) ⬆️

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a squash/history clean up before merging but otherwise good to go

@rakekniven
Copy link
Member Author

Needs a squash/history clean up before merging but otherwise good to go

Please do so. Thanks.

Aligned end of sentences in about dialog.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5427-c1955130492eb427c228a1460a9fcc32a3245db9-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mgallien mgallien merged commit ee4b382 into master Feb 21, 2023
@mgallien mgallien deleted the rakekniven-patch-1 branch February 21, 2023 09:09
@mgallien mgallien added this to the 3.8.0 milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants