Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.7] with cfapi when dehydrating files add missing flag #5484

Merged
merged 1 commit into from
Feb 28, 2023
Merged

[stable-3.7] with cfapi when dehydrating files add missing flag #5484

merged 1 commit into from
Feb 28, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #5474

@mgallien @backportbot-nextcloud
with cfapi when dehydrating files add missing flag
df54ba3 
CF_UPDATE_FLAG_DEHYDRATE is apparently needed to get dehydration to
always succeed

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.7.4 milestone Feb 28, 2023
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5484-df54ba30b7f26c6b07f71e1b2ed44a5b1fcb4e9a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #5484 (df54ba3) into stable-3.7 (b1186e2) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff             @@
##           stable-3.7    #5484   +/-   ##
===========================================
  Coverage       57.83%   57.83%           
===========================================
  Files             141      141           
  Lines           18148    18148           
===========================================
+ Hits            10495    10496    +1     
+ Misses           7653     7652    -1
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/cfapiwrapper.cpp 73.18% <ø> (+0.22%) ⬆️
src/libsync/owncloudpropagator.h 65.07% <0.00%> (-0.80%) ⬇️
src/libsync/propagateremotemkdir.h 75.00% <0.00%> (+25.00%) ⬆️

@mgallien mgallien merged commit a00aba8 into stable-3.7 Feb 28, 2023
@mgallien mgallien deleted the backport/5474/stable-3.7 branch February 28, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@allexzander allexzander Awaiting requested review from allexzander

@camilasan camilasan Awaiting requested review from camilasan

@claucambra claucambra Awaiting requested review from claucambra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.4
Development

Successfully merging this pull request may close these issues.
2 participants
@nextcloud-desktop-bot @mgallien