follow shouldNotify flag to hide notifications when needed #5530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
requested review from
nickvergessen,
camilasan,
allexzander and
claucambra
claucambra
approved these changes
Mar 16, 2023
nickvergessen
added
1. to develop
enhancement
mgallien
force-pushed
the
feature/obeyShouldNotifyFlag
branch
2 times, most recently
from
eba0a45 to
ae51ee8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5530 +/- ##
==========================================
- Coverage 58.94% 58.93% -0.01%
==========================================
Files 143 143
Lines 18314 18314
==========================================
- Hits 10795 10794 -1
- Misses 7519 7520 +1 |
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
feature/obeyShouldNotifyFlag
branch
from
ae51ee8 to
e0bdbd1
Compare
|
AppImage file: nextcloud-PR-5530-e0bdbd138764e1406c5ca2a183c6fa719f428660-x86_64.AppImage |
|
Kudos, SonarCloud Quality Gate passed! |
claucambra
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.