Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/stop after creating config file #5532

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Bugfix/stop after creating config file #5532

merged 3 commits into from
Mar 22, 2023

Conversation

mgallien
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 17, 2023 •
edited
Loading

Codecov Report

Merging #5532 (d2cd4ef) into master (54a11e8) will increase coverage by 0.05%.
The diff coverage is 0.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5532      +/-   ##
==========================================
+ Coverage   58.96%   59.02%   +0.05%     
==========================================
  Files         143      143              
  Lines       18314    18331      +17     
==========================================
+ Hits        10798    10819      +21     
+ Misses       7516     7512       -4
Impacted Files Coverage Δ
src/libsync/configfile.cpp 26.50% <0.00%> (-0.36%) ⬇️
src/libsync/theme.cpp 19.06% <0.00%> (-0.29%) ⬇️
src/libsync/theme.h 60.00% <0.00%> (+10.00%) ⬆️

... and 5 files with indirect coverage changes

mgallien added 3 commits March 22, 2023 10:17
@mgallien
store in config file that we want to enable vfs when generating config
903c475 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
tidy up code in Theme class
85a2020 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
fix the logic generating the config file
d2cd4ef 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/stopAfterCreatingConfigFile branch from 72dd891 to d2cd4ef Compare March 22, 2023 09:17
@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5532-d2cd4efaaa75db81f9bb57b4934adb5e48eda8db-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 04a32cb into master Mar 22, 2023
@mgallien mgallien deleted the bugfix/stopAfterCreatingConfigFile branch March 22, 2023 15:58
@mgallien mgallien added this to the 3.8.0 milestone Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mgallien @nextcloud-desktop-bot @claucambra