Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in case server has no private key, let e2ee init fail #5566

Merged
merged 1 commit into from
Apr 7, 2023
Merged

in case server has no private key, let e2ee init fail #5566

merged 1 commit into from
Apr 7, 2023

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Apr 4, 2023

No description provided.

@mgallien mgallien force-pushed the bugfix/tolerateMissingPrivateKey branch from f76ad3a to 3fc4978 Compare April 6, 2023 09:44
@codecov
Copy link

codecov bot commented Apr 6, 2023 •
edited
Loading

Codecov Report

Merging #5566 (a852eda) into master (b655fce) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5566      +/-   ##
==========================================
- Coverage   59.26%   59.25%   -0.01%     
==========================================
  Files         143      143              
  Lines       18435    18435              
==========================================
- Hits        10925    10924       -1     
- Misses       7510     7511       +1
Impacted Files Coverage Δ
src/libsync/clientsideencryption.cpp 40.85% <0.00%> (ø)

... and 1 file with indirect coverage changes

@mgallien
in case server has no private key, let e2ee init fail
a852eda 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/tolerateMissingPrivateKey branch from 3fc4978 to a852eda Compare April 7, 2023 14:08
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5566-a852eda937e9a96267b049e8e487bf3a1fcf8566-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

allexzander
allexzander approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@allexzander allexzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks

@mgallien mgallien merged commit ef5325e into master Apr 7, 2023
@mgallien mgallien deleted the bugfix/tolerateMissingPrivateKey branch April 7, 2023 15:38
@mgallien
Copy link
Collaborator Author

mgallien commented Apr 7, 2023

/backport to stable-3.8

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 7, 2023
Merged
@mgallien mgallien added this to the 3.9.0 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@allexzander allexzander allexzander approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mgallien @nextcloud-desktop-bot @allexzander @claucambra