Fix crash on entering new log file after file size of 512kb reached #5603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
approved these changes
Apr 13, 2023
|
/backport to stable-3.8 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5603 +/- ##
==========================================
- Coverage 59.28% 59.26% -0.03%
==========================================
Files 143 143
Lines 18445 18453 +8
==========================================
+ Hits 10936 10937 +1
- Misses 7509 7516 +7
|
mgallien
force-pushed
the
bugfix/fix-log-crash
branch
from
8e48fa2 to
e70c51e
Compare
mgallien
approved these changes
Apr 19, 2023
mgallien
force-pushed
the
bugfix/fix-log-crash
branch
from
e70c51e to
210363d
Compare
allexzander
approved these changes
Apr 19, 2023
mgallien
force-pushed
the
bugfix/fix-log-crash
branch
from
210363d to
7af3962
Compare
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
separate public methods that must lock and private methods that must not lock will avoid deadlock or unprotected accesses Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/fix-log-crash
branch
from
7af3962 to
9c8b624
Compare
|
SonarCloud Quality Gate failed. |
|
AppImage file: nextcloud-PR-5603-9c8b624ef7350f649e06e0f16249b0e4e800b4f1-x86_64.AppImage |
|
The backport to stable-3.8 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable-3.8
git pull origin/stable-3.8
# Create the new backport branch
git checkout -b fix/foo-stable-3.8
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable-3.8More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
/backport to stable-3.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are encountering a possible thread-unsafe race condition. Fix is to put this under the existing mutex.