Fix folder progress bar positioning in account settings on macOS #5645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5645 +/- ##
==========================================
+ Coverage 59.25% 59.26% +0.01%
==========================================
Files 143 143
Lines 18450 18450
==========================================
+ Hits 10932 10934 +2
+ Misses 7518 7516 -2 |
allexzander
approved these changes
May 8, 2023
camilasan
approved these changes
May 8, 2023
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
… QMacStyle Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…older settings instead of QCommonStyle Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…legate::paint Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
claucambra
force-pushed
the
bugfix/folder-progress-bar-mac
branch
from
9898c0f to
3960032
Compare
|
AppImage file: nextcloud-PR-5645-396003264cff659428ae89385bbf522455fc2d8b-x86_64.AppImage |
|
/backport to stable-3.8 |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We draw a custom widget for the folder status in the account settings, using QStyle's various drawing methods to render the internal widgets. This works great 99% of the time, except on macOS where
QMacStylehas a bug with drawing progress bars and does not respect X or Y settings in theQStyleOptionProgressBarrect QRect. This means the progress bar gets drawn out of position at the top-left of the folder view.In cases where we are running macOS, default to drawing this progress bar with the Fusion style instead.
This PR also includes a number of code clean ups in the relevant
paintfunction for the folder delegateWith fix:
Before fix: