Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/unsupported filename on server #5801

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

allexzander
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #5801 (bd37b71) into master (392b828) will decrease coverage by 0.18%.
The diff coverage is 10.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5801      +/-   ##
==========================================
- Coverage   60.36%   60.19%   -0.18%     
==========================================
  Files         143      143              
  Lines       18526    18544      +18     
==========================================
- Hits        11183    11162      -21     
- Misses       7343     7382      +39     
Impacted Files Coverage Δ
src/libsync/abstractnetworkjob.cpp 71.10% <0.00%> (-3.70%) ⬇️
src/libsync/abstractnetworkjob.h 53.84% <ø> (ø)
src/libsync/bulkpropagatorjob.cpp 74.71% <ø> (ø)
src/libsync/owncloudpropagator.cpp 84.63% <ø> (ø)
src/libsync/progressdispatcher.cpp 53.48% <ø> (ø)
src/libsync/syncfileitem.h 43.54% <ø> (ø)
src/libsync/propagateupload.cpp 75.54% <20.00%> (-0.83%) ⬇️
src/libsync/syncresult.cpp 36.17% <100.00%> (ø)

... and 8 files with indirect coverage changes

@tobiasKaminsky tobiasKaminsky added this to the 3.9.1 milestone Jun 13, 2023
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only small comments

src/gui/invalidfilenamedialog.h Outdated Show resolved Hide resolved
src/libsync/abstractnetworkjob.h Outdated Show resolved Hide resolved
src/libsync/abstractnetworkjob.h Outdated Show resolved Hide resolved
…w user to rename those via dialog.

Signed-off-by: allexzander <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the bugfix/unsupported-filename-on-server branch from b848a05 to 63470c0 Compare June 14, 2023 10:49
@allexzander allexzander requested a review from mgallien June 14, 2023 11:08
Signed-off-by: alex-z <blackslayer4@gmail.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

7.1% 7.1% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5801-bd37b711fe7d12bc8afc4386421a2dd230c2d57e-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien enabled auto-merge June 14, 2023 14:12
@mgallien mgallien merged commit d57eba8 into master Jun 14, 2023
@mgallien mgallien deleted the bugfix/unsupported-filename-on-server branch June 14, 2023 14:17
@allexzander
Copy link
Contributor Author

/backport to stable-3.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants