Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix. Random crash in LsColJob after recent changes. #6393

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

allexzander
Copy link
Contributor

I caught a random crash caused by my changes in #6336. This needs to be released in RC2 too.

@allexzander
Copy link
Contributor Author

@mgallien Kindly, keep this one in mind. When releasing RC2, fully syncing at least one medium-sized folder (1-2GB) is required to make sure everything works fine. Also, an upload of a folder with multiple files and at least one nested folder with multiple files as well (50-100 small files in total is enough). Otherwise, if something doesn't seem right, kindly revert this and #6336 for RC3.

@allexzander
Copy link
Contributor Author

/backport to stable-3.12

Signed-off-by: alex-z <blackslayer4@gmail.com>
@mgallien mgallien force-pushed the bugfix/fix-random-crash-lscoljob branch from 86b30f5 to 5cdeba8 Compare January 30, 2024 08:34
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6393-5cdeba806167667491480e673a57e28af4e37ead-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit a6e683f into master Jan 30, 2024
10 of 12 checks passed
@mgallien mgallien deleted the bugfix/fix-random-crash-lscoljob branch January 30, 2024 08:48
Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

3 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@mgallien mgallien added this to the 3.13.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants