fix: Nautilus integration conflicts with ownCloud #6418
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
approved these changes
Feb 7, 2024
|
@mgallien Did you see my comment? |
joshtrichards
changed the title
-> fixes conflicts with the ownCloud extension Signed-off-by: mammo0 <marc.ammon@hotmail.de>
|
Hello @mgallien, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
today I stumbled across issue #3803.
After some testing I found out that the culprit are the two Python classes
MenuExtension_ownCloudandSyncStateExtension_ownCloud. They are defined by the Nextcloud and the ownCloud integration.If the names are changed to something else, like
MenuExtension_Nextcloud, then both integrations are working again.Since you are using the code from the ownCloud integration (https://github.com/owncloud/client-desktop-shell-integration-nautilus), the names of the classes should normally be changed by the
setappname.shscript. But this name is branded to "Nextcloud" in this repository. This means the "ownCloud" strings in the integration (syncstate.py) won't get replaced. So I changed the branding back to "ownCloud" and now the strings are correctly replaced during the Cmake build process.