Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create systray notification if there are no errors. #6421

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

camilasan
Copy link
Member

I overlooked this in my PR #6405
I was getting empty systray messages when there was no error.

@camilasan camilasan requested a review from mgallien February 7, 2024 18:49
Signed-off-by: Camila Ayres <hello@camilasan.com>
@mgallien mgallien force-pushed the bugfix/systray-error branch from dca9c93 to 533ef0b Compare February 8, 2024 15:40
@mgallien mgallien merged commit 9d78e97 into master Feb 8, 2024
9 of 12 checks passed
@mgallien mgallien deleted the bugfix/systray-error branch February 8, 2024 15:40
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6421-533ef0b2604ba2b8185daa33227668172dc79e7c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mgallien
Copy link
Collaborator

/backport to stable-3.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants