VFS. CfAPI. Provide detailed error message for leading '#' placeholder update failure. #6456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable-3.12 |
mgallien
approved these changes
Feb 22, 2024
…r update failure. Signed-off-by: alex-z <blackslayer4@gmail.com>
allexzander
force-pushed
the
feature/vfs-cfapi-detailed-error-message-for-leading-hash
branch
from
30a46da to
74bef92
Compare
|
allexzander
deleted the
feature/vfs-cfapi-detailed-error-message-for-leading-hash
branch
|
AppImage file: nextcloud-PR-6456-74bef928a3dc2614697393fb8b56f368d3c00c67-x86_64.AppImage |
Open
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CfUpdatePlaceholder fails in case a path contains any folder with leading '#'. The same happens with CfConvertToPlaceholder. This bug can not be explained, except for a Windows internals issue. Different combinations of parameters do not prevent it from happening. Until we find a better solution, I am adding self-explanatory error messages to help users understand/fix paths.